Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: output can be stdout so you can pipe it to other commands #19

Merged
merged 11 commits into from
Feb 1, 2022
Merged

feat: output can be stdout so you can pipe it to other commands #19

merged 11 commits into from
Feb 1, 2022

Conversation

imreACTmd
Copy link
Collaborator

output now accepts '-' and sends the output to stdout so you can pipe it to other commands.

@imreACTmd imreACTmd requested a review from rap2hpoutre January 8, 2022 15:28
@imreACTmd
Copy link
Collaborator Author

@rap2hpoutre what do you think of this PR?

@rap2hpoutre
Copy link
Owner

Thank you for your contribution!

Why did you change all console.log to console.error? It could seem weird to console.error a "process started" info.

@imreACTmd
Copy link
Collaborator Author

I had to switch the logging statements to STDERR because the new feature is output to STDOUT, and otherwise the log statements would end up in STDOUT and potentially mess up the resulting pg_dump output.

@imreACTmd
Copy link
Collaborator Author

@rap2hpoutre If you prefer me to do it differently, let me know! It's easy enough to change.

@imreACTmd
Copy link
Collaborator Author

@rap2hpoutre does it look good to you?

@rap2hpoutre
Copy link
Owner

I had to switch the logging statements to STDERR because the new feature is output to STDOUT, and otherwise the log statements would end up in STDOUT and potentially mess up the resulting pg_dump output.

That's OK then!

@rap2hpoutre does it look good to you?

Sorry for late answer! Yes we can merge it.

Thank you for your work!!!

rap2hpoutre
rap2hpoutre approved these changes Jan 31, 2022
View reviewed changes
Copy link
Owner

@rap2hpoutre rap2hpoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can click on squash+merge!

@imreACTmd imreACTmd merged commit 11e46ce into rap2hpoutre:main Feb 1, 2022
github-actions bot pushed a commit that referenced this pull request Mar 13, 2022
@semantic-release-bot
chore(release): 0.5.0 [skip ci]
f3a59a9 
# [0.5.0](v0.4.0...v0.5.0) (2022-03-13)

### Features

* add support to specify tables in list of columns ([#13](#13)) ([bc6638d](bc6638d))
* new option to read replacements from a file ([#18](#18)) ([a7c6441](a7c6441))
* output can be stdout so you can pipe it to other commands ([#19](#19)) ([11e46ce](11e46ce))
* table name to extension functions ([#8](#8)) ([9f0a8f8](9f0a8f8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rap2hpoutre rap2hpoutre rap2hpoutre approved these changes

Assignees

@imreACTmd imreACTmd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imreACTmd @rap2hpoutre