Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom delimiter set in configureCsv not used when exporting to CSV #310

Closed
matejjurancic opened this issue Jan 31, 2023 · 0 comments
Closed

Comments

@matejjurancic
Copy link
Contributor

Hi,

first of all thanks for this great package!

I am mainly using it for simple (and fast) exports from DB to CSV such as:

(new FastExcel(SomeModel::get()))->configureCsv(';', "'")->export('export.csv');

But after upgrading openspout/openspout to v4 the options set in configureCsv are no longer taken in consideration as the exported CSV is made with the default delimiter ,. Import on the other hand works as expected.

matejjurancic pushed a commit to matejjurancic/fast-excel that referenced this issue Jan 31, 2023
wahahayay added a commit to wahahayay/LaravelExcelImport that referenced this issue Sep 24, 2023
* Fixes rap2hpoutre/fast-excel#310

* Update tests/IssuesTest.php

---------

Co-authored-by: Matej Jurančič <[email protected]>
Co-authored-by: Raphaël Huchet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant