Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in completion format #538

Closed
antoniopaolini opened this issue Oct 2, 2023 · 2 comments
Closed

Error in completion format #538

antoniopaolini opened this issue Oct 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@antoniopaolini
Copy link

antoniopaolini commented Oct 2, 2023

Bug Report

App Version: [2.0.0-dev13]

Platform: [macOS ]

Installation Method: [Direct Download ]

Bug Description:
If I mark task completed the 1.3.1 version save it moving the priority in property, like pri:C, to be clear.
The 2.0.0-dev13 instead modify the row by adding x in front but leave the priority in place. This conflict with the format rule n°2 for complete task, that say: Rule 2: The date of completion appears directly after the x, separated by a space.

Steps to Reproduce:

  1. Write down a task with priority
  2. mark as completed
  3. open the todo.txt file with a text editor or another todo.txt app (in the screenshots is TodoTxtMac)

Screenshots:
Screenshot 2023-10-02 alle 01 34 52 copia

Screenshot 2023-10-02 alle 01 50 33 copia

System Information:

  • OS Version: [macOS Sonoma]
  • Processor: [M1

Reproducibility:

  • [Always /]

Impact:

  • [Major]
@antoniopaolini antoniopaolini added the bug Something isn't working label Oct 2, 2023
@ransome1 ransome1 moved this to In Progress in sleek 2.x Oct 10, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in sleek 2.x Oct 10, 2023
@ransome1
Copy link
Owner

@antoniopaolini this should be fixed in https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev15. Could you please check if it works on your side?

It has a limitation though. If you restore a todo with pri:, it will not remove the extension itself.

So if x Test pri:A is marked as incomplete again, it will create (A) Test pri:A. This is due to the todo.txt parser not being able to remove extensions yet. It is addressed with them.

@antoniopaolini
Copy link
Author

@antoniopaolini this should be fixed in https://github.com/ransome1/sleek/releases/tag/v2.0.0-dev15. Could you please check if it works on your side?

It has a limitation though. If you restore a todo with pri:, it will not remove the extension itself.

Yes, it's works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants