Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with Python 3.13 #230

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Test with Python 3.13 #230

merged 2 commits into from
Oct 12, 2024

Conversation

henriquegemignani
Copy link
Member

No description provided.

@henriquegemignani henriquegemignani requested a review from a team October 12, 2024 17:45
@codecov Codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.29%. Comparing base (fa92e98) to head (7f18617).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/mercury_engine_data_structures/cli.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   76.37%   76.29%   -0.08%     
==========================================
  Files          76       76              
  Lines        3521     3506      -15     
==========================================
- Hits         2689     2675      -14     
+ Misses        832      831       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Miepee
Miepee reviewed Oct 12, 2024
View reviewed changes
pyproject.toml
@@ -67,7 +68,7 @@ lint.select = ["E", "F", "W", "C90", "I", "UP"]
src = ["src"]

# Version to target for generated code.
target-version = "py38"
target-version = "py310"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since 3.9 is still supported for a whole year, any reason why we dont target that for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing union types as X | Y was introduced in 3.10. I assume those changes needs to be reverted if we would target 3.9.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought they were introduced in 3.9. good to know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be a concern, but meds has requires-python = ">=3.10"

@henriquegemignani henriquegemignani added this pull request to the merge queue Oct 12, 2024
Merged via the queue into main with commit 8ef9048 Oct 12, 2024
11 checks passed
@henriquegemignani henriquegemignani deleted the chore/ci branch October 12, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miepee Miepee Miepee left review comments

@ThanatosGit ThanatosGit ThanatosGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henriquegemignani @Miepee @ThanatosGit