Feature: Support external ESYS_CONTEXT in TPM2 #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ONTEXT* Co-Authored-By: René Meusel <[email protected]>
The ESYS_CONTEXT is managed by the application and will not be finalized by the TPM2::Context. Co-Authored-By: René Meusel <[email protected]>
atreiber94
force-pushed
the
feature/tpm2_external_ctx
branch
from
7055d9d
to
131d29e
Compare
Co-Authored-By: René Meusel <[email protected]>
Co-Authored-By: René Meusel <[email protected]>
atreiber94
force-pushed
the
feature/tpm2_external_ctx
branch
from
131d29e
to
eb74a85
Compare
Co-Authored-By: René Meusel <[email protected]>
atreiber94
force-pushed
the
feature/tpm2_external_ctx
branch
from
eb74a85
to
c9e47b6
Compare
reneme
requested changes
Nov 11, 2024
There was a problem hiding this comment.
I was involved in the development of this patch, pair-programming with @atreiber94. Nevertheless, we forgot to test this with --disabled-modules=tpm2_crypto_backend 😨. Needs a little #ifdef fairy dust, therefore.
Co-authored-by: René Meusel <[email protected]>
atreiber94
force-pushed
the
feature/tpm2_external_ctx
branch
from
192e4dc
to
9fcff47
Compare
reneme
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Don't be scared, the large diff is due to file renaming...)
Certain applications may want the flexibilty to do more than currently possible within
Botan::TPM2and therefore may rely on anESYS_CONTEXTthat is not created via Botan's interface.This results in 2 major use cases:
TPM2::Contextfrom anESYS_CONTEXTmanaged by the applicationThis is useful to selectively benefit from wrapped functionality in Botan while maintaining the flexibility to use all of ESAPI
Unfortunately there is some added complexity because of the different kinds of memory management involved between the different APIs. Externally provided
ESYS_CONTEXTobjects are not retained byTPM2::Context, and are therefore not finalized in its destructor.