Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use expectExceptionMessageMatches for multiple error messages #90

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

rancoud
Copy link
Owner

@rancoud rancoud commented Mar 8, 2022

Description

Because error message is now different with php, I change how the exception message is catched for that specific test: testNetworkExceptionBadURL

Changelist

  • use expectExceptionMessageMatches instead of expectExceptionMessage for testNetworkExceptionBadURL

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #90 (d5f7185) into master (79822c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #90   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       368       368           
===========================================
  Files             11        11           
  Lines            882       882           
===========================================
  Hits             882       882           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79822c9...d5f7185. Read the comment docs.

@rancoud rancoud merged commit 4578b67 into master Mar 8, 2022
@rancoud rancoud deleted the fix-test-network-exception branch March 8, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant