Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test to have parse_url failed on negative port number #14

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

rancoud
Copy link
Owner

@rancoud rancoud commented Dec 5, 2020

Description

In PHP 7.14 parse_url behavior has changed. When showing port number at 0, it will not failed -> https://bugs.php.net/bug.php?id=80266
But this library still raising error when checking port manually

Changelist

  • Change unit test for using negative port number

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #14 (92f52a3) into master (248a8b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     98.62%   98.62%           
  Complexity      371      371           
=========================================
  Files            11       11           
  Lines           870      870           
=========================================
  Hits            858      858           
  Misses           12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248a8b1...92f52a3. Read the comment docs.

@rancoud rancoud merged commit 5a0e521 into master Dec 5, 2020
@rancoud rancoud deleted the error-php714-parse_url branch December 5, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant