Added support for luajit #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is an attempt at compiling zoltan with luajit.
I did not really know how to do conditional compilation, so I used that approach of having different files loaded conditionally through
addPackage.I had to work around a few missing features from luajit and the most questionable one is avoiding to call
lua_setuservalue. I'm no Lua expert so bear with me here. I do not know what is the purpose of this function and looking at other code, especially Lua5.1 binding code, it did not seem necessary.Anyway, let me know if there is anything you'd like to change.
Also, I only tested on osx and Linux. I do not have a windows to try it over there.