Replace deprecated template provider

[benmoss]

https://github.com/hashicorp/terraform-provider-template is deprecated, I was hitting:

╷
│ Error: Incompatible provider version
│
│ Provider registry.terraform.io/hashicorp/template v2.2.0 does not have a package available for your current platform, darwin_arm64.
│
│ Provider releases are separate from Terraform CLI releases, so not all providers are available for all platforms. Other versions of this
│ provider may have different platforms supported.

This updates the places the template provider was being used to use templatefile and the cloudinit provider