Fix schema generation for IntOrString #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IntOrString type is currently generated as a string, which is incorrect. It should use the XIntOrString bool to specify that either integer or string values are allowed. Ref: * https://github.com/kubernetes/apiextensions-apiserver/blob/v0.24.0/pkg/apis/apiextensions/v1/types_jsonschema.go#L107-L120 Signed-off-by: Brad Davidson <[email protected]>
1 task
Oats87
approved these changes
Apr 19, 2023
rmweir
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntOrString type is currently generated as a string, which is incorrect. It should use the XIntOrString bool to specify that either integer or string values are allowed.
Ref: https://github.com/kubernetes/apiextensions-apiserver/blob/v0.24.0/pkg/apis/apiextensions/v1/types_jsonschema.go#L107-L120
There was even a TODO in the code for fixing this once apiextensions hit v1.
Issue Description
Fixes an issue where IntOrString fields with integer values are rejected with messages like:
The HelmChart "cert-manager" is invalid: spec.set.webhook.timeoutSeconds: Invalid value: "integer": spec.set.webhook.timeoutSeconds in body must be of type string: "integer"spec.setis an IntOrString field, but the wrangler-generated openapi v3 schema rejects it as described above.Linked Issue