test: cover azure provisioning via cluster class #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
kind/enhancement
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
e2e-test-cover-aks-clusterclass
branch
from
1b73154
to
9e20288
Compare
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
|
Updated cluster template to reference RKE2 bootstrap object. |
alexander-demicev
approved these changes
Oct 17, 2024
Danil-Grigorev
approved these changes
Oct 17, 2024
furkatgofurov7
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cover AKS cluster provisioning via cluster topology. I suggest deleting the "standard" provisioning test case as the resulting workload cluster is equivalent and the same validation logic is applied to Turtles import/un-import functionality.
Which issue(s) this PR fixes:
Partially solves #693
Special notes for your reviewer:
We can remove the existing AKS test case and use cluster class only in this PR or do it later in a separate one.
The new template will be formatted and re-used as one of the cluster topology example that will be added to Turtles docs. A documentation issue is tracking progress on this here.
Class definition includes a reference to RKE2 because CAPI's webhooks require a bootstrap object reference which, in this case, won't affect during provisioning as AKS is a managed service. This is a known limitation of CAPI and you can refer to kubernetes-sigs/cluster-api#10943 for detailed information on whether this can be fixed and how.
Checklist: