Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add a way to run ETCDRestore controller locally #775

Merged

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Oct 9, 2024

What this PR does / why we need it:
This patch provides an alternative way to run Rancher Turtles locally using the turtles-dev script and Tilt. A new USE_TILT_DEV env var was introduced (set to true by default to keep previous behaviour), and a new way of deploying Turtles uses the locally built helm chart only when set to false.
Additionally, image building for new turtles-etcd-snapshot-restore was taken care by Tilt when used, however it is not when there is no Tilt. To run it without tilt, new Dockerfile to build the image for etcdrestore controller and use the built image in local testing.

Lastly, it changes nightly image publish GH action to publish etcdrestore image as part of the GHA.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes: #765

Special notes for your reviewer:
When running uninstall locally with these changes, snapshot restore controller was cleaned up together with RT controller without any issues

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner October 9, 2024 10:05
@furkatgofurov7 furkatgofurov7 force-pushed the add-etcdrestore-local-image-building branch from f24145b to 5db5077 Compare October 9, 2024 19:42
@furkatgofurov7 furkatgofurov7 added area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature kind/feature labels Oct 9, 2024
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @furkatgofurov7. I just suggested a minor change, but it is not a blocker at all, let me know what you think. Otherwise, it looks good to me.

Makefile Outdated Show resolved Hide resolved
@furkatgofurov7 furkatgofurov7 force-pushed the add-etcdrestore-local-image-building branch from 5db5077 to 4a1f54d Compare October 17, 2024 13:32
@salasberryfin salasberryfin merged commit 92c403e into rancher:main Oct 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature kind/feature
Development

Successfully merging this pull request may close these issues.

Remove etcd snapshot controller during Turtles uninstall
3 participants