Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add helm labels to allow chart downgrade #767

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

What this PR does / why we need it:

Ensure labels match previous helm release for clusterctl-config ConfigMap, which will allow chart validation to pass during downgrade.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

- Ensure labels match to previous release for clusterctl-config CM

Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner October 3, 2024 11:09
@Danil-Grigorev Danil-Grigorev changed the title Add helm labels to allow chart downgrade 🐛 Add helm labels to allow chart downgrade Oct 3, 2024
@Danil-Grigorev Danil-Grigorev added the kind/bug Something isn't working label Oct 3, 2024
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, LGTM.

@Danil-Grigorev Danil-Grigorev merged commit 39f90d1 into rancher:main Oct 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants