New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GHA release workflow #330

Merged

brandond merged 2 commits into rancher:master from brandond:fix-create-release

Sep 25, 2024

Member

brandond commented Sep 25, 2024 •

edited

Loading

Fixes issue where releases would be left without assets if the tag was created by the GH release UI, as the release would already exist.
Fixes issue where arm64 image is overwriting the amd64 image

brandond added 2 commits

September 25, 2024 20:43


          Fix uploading artifacts to existing release

c2f5f21

Fixes issue where releases would be left without assets if the tag was created by the GH release UI, as the release would already exist.

Signed-off-by: Brad Davidson <[email protected]>


          Fix arm64 image clobbering amd64 image

37c3eea

Use build-push-action platforms instead of job matrix to build and publish the image

Signed-off-by: Brad Davidson <[email protected]>

brandond changed the title ~~Fix uploading artifacts to existing release~~ Fix GHA release workflow

briandowns approved these changes

View reviewed changes

brandond merged commit 3835c95 into rancher:master

2 checks passed

lumiere-bot bot referenced this pull request in coolguy1771/home-ops


          feat(container): update system upgrade controller group ( v0.13.4 → v…

4930bb7

…0.14.0 ) (minor) (#5496)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| docker.io/rancher/system-upgrade-controller | minor | `v0.13.4` ->
`v0.14.0` |
|
[rancher/system-upgrade-controller](https://redirect.github.com/rancher/system-upgrade-controller)
| minor | `v0.13.4` -> `v0.14.0` |

---

### Release Notes

<details>
<summary>rancher/system-upgrade-controller
(rancher/system-upgrade-controller)</summary>

###
[`v0.14.0`](https://redirect.github.com/rancher/system-upgrade-controller/releases/tag/v0.14.0)

[Compare
Source](https://redirect.github.com/rancher/system-upgrade-controller/compare/v0.13.4...v0.14.0)

##### What's Changed

- fix: Drop unneeded reorder surpression by
[@&#8203;SISheogorath](https://redirect.github.com/SISheogorath) in
[https://github.com/rancher/system-upgrade-controller/pull/296](https://redirect.github.com/rancher/system-upgrade-controller/pull/296)
- Update/fix README kustomize command by
[@&#8203;SISheogorath](https://redirect.github.com/SISheogorath) in
[https://github.com/rancher/system-upgrade-controller/pull/297](https://redirect.github.com/rancher/system-upgrade-controller/pull/297)
- Add GHA workflows by
[@&#8203;bfbachmann](https://redirect.github.com/bfbachmann) in
[https://github.com/rancher/system-upgrade-controller/pull/311](https://redirect.github.com/rancher/system-upgrade-controller/pull/311)
- Upgrade outdated golang dependencies by
[@&#8203;harsimranmaan](https://redirect.github.com/harsimranmaan) in
[https://github.com/rancher/system-upgrade-controller/pull/326](https://redirect.github.com/rancher/system-upgrade-controller/pull/326)
- feat: allow pod replacement policy override by
[@&#8203;buroa](https://redirect.github.com/buroa) in
[https://github.com/rancher/system-upgrade-controller/pull/328](https://redirect.github.com/rancher/system-upgrade-controller/pull/328)
- fix: system-upgrade-controller-drainer: add missing delete permission
for pods in clusterrole by
[@&#8203;damdo](https://redirect.github.com/damdo) in
[https://github.com/rancher/system-upgrade-controller/pull/320](https://redirect.github.com/rancher/system-upgrade-controller/pull/320)
- Bump golang.org/x/net from 0.17.0 to 0.23.0 in /pkg/apis by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/rancher/system-upgrade-controller/pull/307](https://redirect.github.com/rancher/system-upgrade-controller/pull/307)
- Fix GHA release workflow by
[@&#8203;brandond](https://redirect.github.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/330](https://redirect.github.com/rancher/system-upgrade-controller/pull/330)
- Fix image tag by
[@&#8203;brandond](https://redirect.github.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/331](https://redirect.github.com/rancher/system-upgrade-controller/pull/331)
- Fix artifact permissions by
[@&#8203;brandond](https://redirect.github.com/brandond) in
[https://github.com/rancher/system-upgrade-controller/pull/332](https://redirect.github.com/rancher/system-upgrade-controller/pull/332)

##### New Contributors

- [@&#8203;bfbachmann](https://redirect.github.com/bfbachmann) made
their first contribution in
[https://github.com/rancher/system-upgrade-controller/pull/311](https://redirect.github.com/rancher/system-upgrade-controller/pull/311)
- [@&#8203;harsimranmaan](https://redirect.github.com/harsimranmaan)
made their first contribution in
[https://github.com/rancher/system-upgrade-controller/pull/326](https://redirect.github.com/rancher/system-upgrade-controller/pull/326)
- [@&#8203;damdo](https://redirect.github.com/damdo) made their first
contribution in
[https://github.com/rancher/system-upgrade-controller/pull/320](https://redirect.github.com/rancher/system-upgrade-controller/pull/320)

**Full Changelog**:
rancher/system-upgrade-controller@v0.13.4...v0.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NS40IiwidXBkYXRlZEluVmVyIjoiMzguOTUuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL21pbm9yIl19-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet