Fix Spec.Drain.PodSelector #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use helpers instead of string ops to handle pod selector generation Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix_drain_labelselector
branch
from
f1b085e
to
7cf72a0
Compare
briandowns
approved these changes
May 5, 2023
manuelbuil
approved these changes
May 5, 2023
Stackclash
referenced
this pull request
in Stackclash/home-cluster
May 25, 2023
….11.0 (#887) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller) | Kustomization | minor | `v0.10.0` -> `v0.11.0` | --- ### Release Notes <details> <summary>rancher/system-upgrade-controller</summary> ### [`v0.11.0`](https://togithub.com/rancher/system-upgrade-controller/releases/tag/v0.11.0) [Compare Source](https://togithub.com/rancher/system-upgrade-controller/compare/v0.10.0...v0.11.0) ##### What's Changed - Add support for PodSelector in DrainSpec by [@​brandond](https://togithub.com/brandond) in [https://github.com/rancher/system-upgrade-controller/pull/231](https://togithub.com/rancher/system-upgrade-controller/pull/231) - Set Kubernetes owner references on Job objects by [@​brandond](https://togithub.com/brandond) in [https://github.com/rancher/system-upgrade-controller/pull/235](https://togithub.com/rancher/system-upgrade-controller/pull/235) - examples: add upgrade YAML for MicroOS by [@​aplanas](https://togithub.com/aplanas) in [https://github.com/rancher/system-upgrade-controller/pull/237](https://togithub.com/rancher/system-upgrade-controller/pull/237) - Fix Spec.Drain.PodSelector by [@​brandond](https://togithub.com/brandond) in [https://github.com/rancher/system-upgrade-controller/pull/239](https://togithub.com/rancher/system-upgrade-controller/pull/239) - Bump github.com/rancher/wrangler from 0.8.11-0.20230207214913-209077f2d98f to 0.8.11 in /pkg/apis by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/rancher/system-upgrade-controller/pull/233](https://togithub.com/rancher/system-upgrade-controller/pull/233) ##### New Contributors - [@​aplanas](https://togithub.com/aplanas) made their first contribution in [https://github.com/rancher/system-upgrade-controller/pull/237](https://togithub.com/rancher/system-upgrade-controller/pull/237) **Full Changelog**: rancher/system-upgrade-controller@v0.10.0...v0.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/RickCoxDev/home-cluster). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use helpers instead of string ops to handle pod selector generation.
The previous logic was generating invalid LabelSelector strings, and the e2e test didn't catch it because it was just looking for a substring, not the full LabelSelector value.