Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump apiserver #73

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Bump apiserver #73

merged 2 commits into from
Jan 20, 2023

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Jan 20, 2023 •
edited
Loading

Bump apiserver and fix unrelated tests.

rancher/rancher#40196

@cmurphy cmurphy marked this pull request as draft January 20, 2023 22:07
@cmurphy
Fix resource counts unit tests
9a386b2 
Increase the timeout slightly to avoid the occasional premature timeout.
Fix error message typo.
@cmurphy cmurphy marked this pull request as ready for review January 20, 2023 22:20
MbolotSuse
MbolotSuse approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@MbolotSuse MbolotSuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the flaky test.

@cmurphy cmurphy merged commit 53fbb87 into rancher:master Jan 20, 2023
@gaktive gaktive mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MbolotSuse MbolotSuse MbolotSuse approved these changes

@KevinJoiner KevinJoiner Awaiting requested review from KevinJoiner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmurphy @MbolotSuse