Add aggregation layer support #316
Draft
+722
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
reviewed
Nov 4, 2024
| // auth := NewUnionAuthenticator(customAuth, default) | ||
| // err = auth.RunOnce(ctx) | ||
| func NewUnionAuthenticator(authenticators ...authenticator.Request) *UnionAuthenticator { | ||
| caContentProviders := make([]dynamiccertificates.CAContentProvider, 0, len(authenticators)) |
There was a problem hiding this comment.
This could be simplified to...
var caContentProviders []dynamiccertificates.CAContentProvider| opts.Authenticator = auth | ||
| }, nil) | ||
| require.NoError(t, err) | ||
| defer cleanup() |
There was a problem hiding this comment.
It feels like setupExtensionAPIServer could call t.Cleanup() rather than having to return a cleanup function?
| }, | ||
| }, | ||
| } | ||
| req, err := http.NewRequest(http.MethodGet, fmt.Sprintf("https://127.0.0.1:%d%s", port, "/openapi/v2"), nil) |
There was a problem hiding this comment.
This could be simplified to fmt.Sprintf("https://127.0.0.1:%d/openapi/v2", port) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue rancher/rancher#47540
Implements the default authentication.
This was original part of #287 but was split up to make it easier to review.