[v2.9] Backport PR 271: Index more sqlite cache fields. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moio
previously approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Patches are semantically identical to the originals apart from dependency versions, which is expected.
#271 :
git range-diff 63683abbf478aa2dd6f5cb492f6c75130d6e05e7~..63683abbf478aa2dd6f5cb492f6c75130d6e05e7 06c2eb50d11d4f07f7a690e4bc0f71a805a114ee~..06c2eb50d11d4f07f7a690e4bc0f71a805a114ee
#291 :
git range-diff 6a11ffb66087599f9ec301eecb44841b0c276b10~..6a11ffb66087599f9ec301eecb44841b0c276b10 7dd4cbefea2f7e35346038e190dd3de12bcd7c8f~..7dd4cbefea2f7e35346038e190dd3de12bcd7c8f
LGTM
tomleb
requested changes
Oct 31, 2024
There was a problem hiding this comment.
I would suggest just backporting the PR from 271 and not the uber bump as well. The uber change could cause problem or major changes when bumping steve in rancher/rancher. eg: Quite a few changes (although trivial): rancher/rancher#47128.
We're gonna be in code freeze by EOD so let's minimize the impact and just go with the 271 backport (at least for this PR)
moio
force-pushed
the
47788-backport-46642-to-2.9
branch
from
7dd4cbe to
63683ab
Compare
|
#291 removed |
Signed-off-by: Silvio Moioli <[email protected]>
moio
approved these changes
Oct 31, 2024
|
Validation failed for me without #291, but I see it's passing CI. OK... |
moio
added a commit
to moio/rancher
that referenced
this pull request
Nov 4, 2024
This includes commits from the following PRs to address issues in UI Server-Side Pagination: rancher/steve#315 (add indexed fields) rancher/steve#312 (add missing object information) Signed-off-by: Silvio Moioli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.