Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drone validate build #109

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

moio
Copy link
Contributor

@moio moio commented Jun 7, 2023

go1.19 provides go=1.19.9, the right symbol for the major version is golang(API)

See https://build.opensuse.org/package/view_file/openSUSE:Factory/go1.19/go1.19.spec?expand=1

go1.19 provides go=1.19.9, the right symbol for the major version is golang(API)

Signed-off-by: Silvio Moioli <[email protected]>
Copy link
Contributor

@MbolotSuse MbolotSuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix. I think this works, although go1.19 also seems to work, but I'll default to you on the best way to get the matching version of go that we want.

@MbolotSuse MbolotSuse merged commit 3cbeea2 into rancher:master Jun 7, 2023
@moio
Copy link
Contributor Author

moio commented Jun 9, 2023

go1.19 also seems to work, but I'll default to you on the best way to get the matching version of go that we want.

Indeed the difference is tiny - the only advantage in relying on the symbol instead of the package name means that the package name could be renamed without us being affected.

I will not be against just using go1.19 if that's easier to understand for non-SLE-centric developers. ☮️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants