Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.30] rke2-runtime signing and manifests (#7089) #7101

Merged

Conversation

brooksn
Copy link
Contributor

@brooksn brooksn commented Oct 22, 2024

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@brooksn brooksn requested a review from a team as a code owner October 22, 2024 21:34
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.62%. Comparing base (47c5362) to head (6c4051e).

❗ There is a different number of reports uploaded between BASE (47c5362) and HEAD (6c4051e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (47c5362) HEAD (6c4051e)
inttests 1 0
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.30    #7101      +/-   ##
================================================
- Coverage         23.38%   16.62%   -6.77%     
================================================
  Files                33       32       -1     
  Lines              3438     3423      -15     
================================================
- Hits                804      569     -235     
- Misses             2587     2812     +225     
+ Partials             47       42       -5     
Flag Coverage Δ
inttests ?
unittests 16.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brooksn brooksn merged commit 26079d1 into rancher:release-1.30 Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants