add org.opencontainers.image url and source labels to dockerfiles #6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sankalp Yengaldas <[email protected]>
|
Hi @brandond and @matttrach, could you please help with review and approval of this PR. |
brandond
requested changes
Oct 9, 2024
Signed-off-by: Sankalp Yengaldas <[email protected]>
brandond
approved these changes
Oct 10, 2024
brandond
requested changes
Oct 10, 2024
Signed-off-by: Sankalp Yengaldas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6962 +/- ##
==========================================
- Coverage 25.11% 25.09% -0.02%
==========================================
Files 33 33
Lines 2839 2841 +2
==========================================
Hits 713 713
- Misses 2079 2081 +2
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Oct 16, 2024
vitorsavian
approved these changes
Oct 16, 2024
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Oct 16, 2024
…ncher#6962) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Oct 16, 2024
…ncher#6962) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Oct 16, 2024
…ncher#6962) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Oct 16, 2024
…ncher#6962) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Oct 16, 2024
) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Oct 16, 2024
) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Oct 16, 2024
) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Oct 16, 2024
) * add org.opencontainers.image url and source labels to dockerfiles Signed-off-by: Sankalp Yengaldas <[email protected]> (cherry picked from commit f76a13f) Signed-off-by: Brad Davidson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR adds the image metadata labels to rke2-runtime image
Types of Changes
enhancement
Verification
check rke2-runtime image labels
Testing
Linked Issues
User-Facing Change
Further Comments