-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updatecli: add typefilter latest: true
#6371
updatecli: add typefilter latest: true
#6371
Comments
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
Ensure UpdateCli chooses the tagged `latest` release, instead of choosing the most recent chronological release Fixes: rancher/rke2#6371 Signed-off-by: Michael Fritch <[email protected]>
@mgfritch If you are sure that the version to monitor is always following semantic versioning then it would be better to use something like
The reason is because the version "latest" version means different things depending on the context. You could enforce this by specifying you are looking for the latest from a semver point of vue and you could also have version pattern like
|
Hey, thanks @olblak ! 👋 Generally, we select a release based on what's tagged as the latest (stable) upstream and then package/validate this release via our downstream chart(s). Your first I'm a little unclear on the documentation, but maybe this can be accomplished by setting |
It makes sense
I usually advance to not commit to a directly to the main branch without some sort of validation because then you put a lot of trust on that upstream dependency maintainer
I don't see a way to achieve that in the current situation. |
Using the attached PR as an example, we could have merged the one desired pull request while closing out any additional undesired pull requests ... However, maybe that would be a moot issue if we had used the |
We need to ensure UpdateCli is choosing the tagged
latest
release,instead of creating PRs that actually bump the version backward by
selecting the most recent chronological release
See also: rancher/image-build-node-feature-discovery#35
The text was updated successfully, but these errors were encountered: