Pass CNI confDir and binDir through to whereabouts pod env #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <[email protected]>
thomasferrandiz
approved these changes
Oct 21, 2024
rbrtbnfgl
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the correct kubeconfig path is written into whereabouts.conf. Ref:
Without this change, the kubeconfig path in the config file is always set to
/etc/cni/net.d/whereabouts.d/whereabouts.kubeconfigeven if this path is actually mounted from elsewhere on the host, which leads to problems when the whereabouts plugin reads the config file and doesn't find the kubeconfig at the expected location.See k3s-io/k3s#10869 (comment) for an example of how this can be worked around. Note that
configuration_pathalways needs to be overridden in the NetworkAttachmentDefinition for K3s, as there is no way to globally set the config dir for the whole plugin chain; most things assume /etc/cni/net.d or /etc/kubernetes/cni/net.d.