WIP: Fix ca linefeed #15452
Closed
WIP: Fix ca linefeed #15452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-jenan-rancher
force-pushed
the
fix-ca-linefeed
branch
2 times, most recently
from
ce8c01f to
6f4194f
Compare
Adding logic to strip preceding and following newliens from ca certs so that checksums are calculated properly. This is to fix an issue where rancher-agents could not connect to rancher. Issue: rancher#13831
nathan-jenan-rancher
force-pushed
the
fix-ca-linefeed
branch
from
6f4194f to
822f026
Compare
|
LGTM once vendor is updated. |
|
closed in favor of #15452, which had vendor.conf updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logic to strip preceding and following newliens from ca certs so that
checksums are calculated properly. This is to fix an issue where
rancher-agents could not connect to rancher.
Issue:
#13831
Depends on:
rancher/norman#194