-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase project monitoring #89
Merged
joshmeranda
merged 12 commits into
rancher:main
from
joshmeranda:rebase-project-monitoring
Jul 3, 2024
Merged
Rebase project monitoring #89
joshmeranda
merged 12 commits into
rancher:main
from
joshmeranda:rebase-project-monitoring
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…37c1ae25cae9ebe2159
joshmeranda
force-pushed
the
rebase-project-monitoring
branch
from
July 1, 2024 18:47
5c19efa
to
c485840
Compare
Overall looked pretty good in my initial review and testing. |
alexandreLamarre
approved these changes
Jul 2, 2024
mallardduck
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
rancher/rancher#44614
Checklist
Please fill out this table to identify which fields need to be modified in your PR.
Under
Status
, either indicateDoes Not Apply
orAdded to this PR
.version
in rancher-project-monitoringpackage.yaml
rancher-project-monitoring
chart to make changeshelmProjectOperator.image.tag
in prometheus-federatorvalues.yaml
main.go
fileappVersion
in prometheus-federatorChart.yaml
helmProjectOperator.image.tag
in the above boxversion
in prometheus-federatorChart.yaml
appVersion
in the above box or you modified the contents of theprometheus-federator
chart to make changes