Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase project monitoring #89

Merged
merged 12 commits into from
Jul 3, 2024

Conversation

joshmeranda
Copy link
Contributor

Related Issue:

rancher/rancher#44614

Checklist

Please fill out this table to identify which fields need to be modified in your PR.

Under Status, either indicate Does Not Apply or Added to this PR.

Version to be incremented Why should this be modified? Status
version in rancher-project-monitoring package.yaml You modified the contents of the rancher-project-monitoring chart to make changes yes
helmProjectOperator.image.tag in prometheus-federator values.yaml Either you modified the rancher-project-monitoring chart or you modified the main.go file n/a
appVersion in prometheus-federator Chart.yaml You modified the helmProjectOperator.image.tag in the above box n/a
version in prometheus-federator Chart.yaml Either you modified the appVersion in the above box or you modified the contents of the prometheus-federator chart to make changes yes

@joshmeranda joshmeranda requested a review from a team as a code owner July 1, 2024 18:31
@joshmeranda joshmeranda force-pushed the rebase-project-monitoring branch from 5c19efa to c485840 Compare July 1, 2024 18:47
@mallardduck
Copy link
Member

Overall looked pretty good in my initial review and testing.
Please shoot me a ping on slack once you're ready for a re-review.

Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshmeranda joshmeranda merged commit 734fcff into rancher:main Jul 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants