Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing version specific annotations inside federator/project monitoring Chart.yaml files. #74

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

geethub97
Copy link
Contributor

@geethub97 geethub97 commented Jun 29, 2023

Removing version specific chart annotations from the upstream chart. Patch them in from the charts repo to avoid unnecessary maintenance down the line.

Related Issue: rancher/rancher#41973

Checklist

Please fill out this table to identify which fields need to be modified in your PR.

Under Status, either indicate Does Not Apply or Added to this PR.

Version to be incremented Why should this be modified? Status
version in rancher-project-monitoring package.yaml You modified the contents of the rancher-project-monitoring chart to make changes Added to this PR
helmProjectOperator.image.tag in prometheus-federator values.yaml Either you modified the rancher-project-monitoring chart or you modified the main.go file Does Not Apply
appVersion in prometheus-federator Chart.yaml You modified the helmProjectOperator.image.tag in the above box Does Not Apply
version in prometheus-federator Chart.yaml Either you modified the appVersion in the above box or you modified the contents of the prometheus-federator chart to make changes Added to this PR

@geethub97 geethub97 requested a review from aiyengar2 as a code owner June 29, 2023 22:53
@geethub97 geethub97 changed the title Updating k8s compatibility annotations inside federator/project monitoring Chart.yaml files. Removing version specific annotations inside federator/project monitoring Chart.yaml files. Jun 29, 2023
Copy link

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine in this repository, cause it means that you can install the Prometheus Federator chart from this repository (if you were to add it as a repository in Rancher) in any Rancher or any Kubernetes version.

However, we should be careful that we’re still re-introducing these annotations when we bring it into rancher/charts, since that should be scoped per Rancher minor by annotation.

LGTM

@geethub97
Copy link
Contributor Author

The plan is to patch them in from the charts repo to avoid unnecessary maintenance for different rancher lines.

@geethub97 geethub97 merged commit 002944b into rancher:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants