This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Fix DHCP hostname being overwritten #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwget
force-pushed
the
fix-dhcp-hostname
branch
4 times, most recently
from
e26f1e6 to
7fee359
Compare
joshwget
force-pushed
the
fix-dhcp-hostname
branch
from
7fee359 to
a0ae622
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rancher/netconf#12
Adds a
default_hostnameattribute which is used to distinguish between a user set hostname and the one specified inos-config.yml.DHCP will only be given the
-e force_hostname=trueflag if the user doesn't set a hostname in the cloud config. DHCP won't change the hostname without this flag.Some hostname functionality was moved out of
cmd/cloudinit/cloudinit.goandcmd/network/network.goto a separate hostname package.#829
#863