Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go test in CI #477

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Run go test in CI #477

merged 2 commits into from
Apr 10, 2024

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Feb 14, 2024

Issue rancher/rancher#44474

The test script is not running in the ci script.

The changes:

  • Run the test script in the ci script
  • Move dapper image to v0.6.0 as that is the latest image (2 years old). The 1.11.2 version is 7 years old according to docker hub.

I have dropped the following changes:

  • The git command added allows users on linux to run dapper with DAPPER_MODE=bind which makes builds a bit faster by not requiring the repository to be copied, a bind mount can be used instead.
    • I'm not sure that's the proper way to fix this, need more investigation from me.
  • Add volumes for caching go modules. This also makes the build faster.
    • This caching might work differently on GHA so instead of making it work both here and later, I'll defer to when we migrate to GHA.
  • Run CI on arm64 in drone: Let's not add anything in drone unless necessary.

@tomleb tomleb marked this pull request as ready for review February 15, 2024 12:42
@tomleb tomleb force-pushed the add-ci branch 2 times, most recently from 345712f to 724c02d Compare February 15, 2024 15:58
scripts/ci Outdated Show resolved Hide resolved
@tomleb
Copy link
Contributor Author

tomleb commented Apr 9, 2024

I have updated the PR by removing the following:

I have dropped the following changes:

  • The git command added allows users on linux to run dapper with DAPPER_MODE=bind which makes builds a bit faster by not requiring the repository to be copied, a bind mount can be used instead.
  • I'm not sure that's the proper way to fix this, need more investigation from me.
  • Add volumes for caching go modules. This also makes the build faster.
  • This caching might work differently on GHA so instead of making it work both here and later, I'll defer to when we migrate to GHA.
  • Run CI on arm64 in drone: Let's not add anything in drone unless necessary.

I have also changed the order of script called in script/ci.

@tomleb tomleb merged commit 7214b58 into rancher:master Apr 10, 2024
1 check passed
@tomleb tomleb deleted the add-ci branch April 10, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants