Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated wait.Poll with wait.PollUntilContextTimeout #457

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

vardhaman22
Copy link
Contributor

@vardhaman22 vardhaman22 commented Aug 31, 2023

related issue: rancher/rancher#41840
to fix linting error:

store/crd/init.go:138:9: SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
        return wait.Poll(500*time.Millisecond, 60*time.Second, func() (bool, error) {
               ^
             ```

@vardhaman22 vardhaman22 requested a review from kinarashah August 31, 2023 06:51
Copy link
Member

@kinarashah kinarashah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinarashah kinarashah merged commit 5de27f6 into rancher:master Aug 31, 2023
@MbolotSuse MbolotSuse mentioned this pull request Jan 26, 2024
@tomleb tomleb mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants