-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting proxy url in client opts #453
Conversation
Hmm, this disables @sboschman what's wrong with passing the proxy via the environment ? |
The idea is to use The problem with passing the proxy via the env is described in the linked issue. It sets the same proxy for every Terraform provider as the env is picked up by golang internally. If the proxy is only for the Rancher provider, but not for any other provider used in the same terraform run you are stuck. |
Since the change is in Norman, assigning team responsible for this component instead. FYI @cbron @samjustus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nitpick, but outside of that LGTM. Keep in mind that we will hold off on merging this until we have a second approval as well.
prerequisite to support rancher/terraform-provider-rancher2#982