Use original crd if already exists #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes concurrent CRD creation.
Multiple Rancher replicas concurrently create CRDs. According to implementation, empty CRD struct will be used if CRD already exists, which cause Rancher panic (but succeed on next pod restart when all CRDs already created).
Empty structure generated in https://github.com/kubernetes/apiextensions-apiserver/blob/master/pkg/client/clientset/clientset/typed/apiextensions/v1beta1/customresourcedefinition.go#L108
Original CRD struct should be used if AlreadyExists https://github.com/rancher/norman/blob/master/store/crd/init.go#L199
Panic happens here https://github.com/rancher/norman/blob/master/store/crd/init.go#L65 because of usage of empty CRD structure with uninitialized fields (crd.Name)
It doesn't break the whole deployment, but increase deployment time because of Rancher restart.