add method to compare if error has tmp file path #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjellick
reviewed
Aug 17, 2018
condition/condition.go
Outdated
| @@ -4,6 +4,8 @@ import ( | |||
| "reflect" | |||
| "time" | |||
|
|
|||
There was a problem hiding this comment.
no newline here. strings should be in the same block of imports as time and reflect
StrongMonkey
force-pushed
the
fix-random-string
branch
7 times, most recently
from
0df1cc1 to
1fe673c
Compare
add a method to check if the error message contains a tmp file path. It is to prevent updating resource's condition forever and causing the controller flapping. rancher/rancher#15103
StrongMonkey
force-pushed
the
fix-random-string
branch
from
1fe673c to
bb99767
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a method to check if the error message contains a tmp file path. It
is to prevent updating resource's condition forever and causing the
controller flapping. rancher/rancher#15103