Update k8s vendor to 1.10.5 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leader/leader.go
Outdated
| @@ -73,5 +73,5 @@ func createRecorder(name string, kubeClient kubernetes.Interface) record.EventRe | |||
| eventBroadcaster := record.NewBroadcaster() | |||
| eventBroadcaster.StartLogging(logrus.Infof) | |||
| eventBroadcaster.StartRecordingToSink(&v1core.EventSinkImpl{Interface: v1core.New(kubeClient.CoreV1().RESTClient()).Events("")}) | |||
| return eventBroadcaster.NewRecorder(api.Scheme, v1.EventSource{Component: name}) | |||
| return eventBroadcaster.NewRecorder(runtime.NewScheme(), v1.EventSource{Component: name}) | |||
There was a problem hiding this comment.
this, I believe should be k8s.io/kubernetes/pkg/api/legacyscheme.Scheme
added 2 commits
July 11, 2018 16:42
jordanjean
pushed a commit
to jordanjean/norman
that referenced
this pull request
Jan 7, 2020
Add desired nodes support on eks_config argument on rancher2_cluster resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rancher/rancher#14311