Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the rke2 charts to v3.19.2 #642

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

manuelbuil
Copy link
Contributor

This update fixes the issue with the ClusterIP by disabling VXLAN tunnel checksum offload on kernels <v5.7. Works around projectcalico/calico#3145.

Signed-off-by: Manuel Buil [email protected]

brandond
brandond previously approved these changes Aug 10, 2021
brandond
brandond previously approved these changes Aug 10, 2021
@aiyengar2 aiyengar2 requested a review from kinarashah August 10, 2021 18:12
Copy link
Contributor

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on @kinarashah to approve

@@ -97,10 +97,10 @@ releases:
version: v3.13.300-build2021022306
rke2-calico:
repo: rancher-rke2-charts
verion: v3.19.1-105
verion: v3.19.2-201
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, why does this say verion instead of version. Is that a bug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I did not see that. Let me change it too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was introduced in 9b7f59b.

I'm not sure if there are any other repercussions for this, so maybe we should double check with the rest of the team. Could be related to an open issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect that calico does not deploy correctly but I haven't tested deploying from Rancher. You tested it when you created this issue rancher/rke2#1541, right?

Copy link
Contributor

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiyengar2 aiyengar2 merged commit 427b326 into rancher:dev-v2.6 Aug 10, 2021
@deniseschannon
Copy link

rancher/rancher#33052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants