This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Update README #373
Merged
Update README #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
Update README.md
dweomer
reviewed
Feb 6, 2020
README.md
Outdated
| Example | ||
| ```bash | ||
| #!/bin/sh | ||
| exec "k3s" "server" "--cluster-cidr 10.107.0.0/23" "--service-cidr 10.107.1.0/23" |
There was a problem hiding this comment.
exec "k3s" "server" "--cluster-cidr 10.107.0.0/23" "--service-cidr 10.107.1.0/23"
This is exactly the kind of thing folks have been tripping over. It should be either of the below:
exec "k3s" "server" "--cluster-cidr=10.107.0.0/23" "--service-cidr=10.107.1.0/23"exec "k3s" "server" "--cluster-cidr" "10.107.0.0/23" "--service-cidr" "10.107.1.0/23"
There was a problem hiding this comment.
Ah ok missed that part! I'll make that edit, thanks man :)
dweomer
suggested changes
Feb 6, 2020
There was a problem hiding this comment.
Thank you for the contribution @jdbohrman, I do appreciate it!
Please see my comments for requested corrections.
dweomer
reviewed
Feb 6, 2020
| - server | ||
| - "--disable-agent" | ||
| - "--cluster-cidr" "10.107.0.0/23" |
There was a problem hiding this comment.
These are two separate args and therefore should be two separate array entries. Please see the above comment.
There was a problem hiding this comment.
This commend applies here too: #373 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for
k3os.k3s_argsto better explain syntax