Update whereabouts v0.6.2 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgfritch
force-pushed
the
update-v0.6.2
branch
2 times, most recently
from
85ccdc4 to
61edeb3
Compare
manuelbuil
reviewed
Jul 14, 2023
| @@ -50,4 +50,4 @@ image-manifest: | |||
|
|
|||
| .PHONY: image-scan | |||
| image-scan: | |||
| trivy --severity $(SEVERITIES) --no-progress --ignore-unfixed $(ORG)/hardened-whereabouts:$(TAG) | |||
| trivy --severity $(SEVERITIES) --no-progress --ignore-unfixed image $(ORG)/hardened-whereabouts:$(TAG) | |||
There was a problem hiding this comment.
Does this mean that image-scan was not working?
There was a problem hiding this comment.
yes, the update to the newer go tag was causing CI to fail because the updated trivy image requires a scanning command
Also update to Go v1.20.6b2 Signed-off-by: Michael Fritch <[email protected]>
manuelbuil
approved these changes
Jul 14, 2023
briandowns
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update to Go v1.20.6b2