-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Github Actions #39
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
- name: Build container image | ||
uses: docker/build-push-action@v5 | ||
with: | ||
context: . | ||
push: false | ||
tags: rancher/hardened-k8s-metrics-server:${{ env.TAG }}-arm64 | ||
file: Dockerfile | ||
outputs: type=docker | ||
platforms: linux/arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, we did something similar in other repos, where you can still benefit from cross-arch cache while still being able to have arch-specific tags:
https://github.com/rancher/cis-operator/blob/master/.github/workflows/release.yml#L42-L44
May not be as relevant as we centralised the logic on the Makefile
instead of leaning on GH actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main recommendation is to follow the least privilege when generating the token, as Paulo suggested.
e0c4290
to
30b2159
Compare
d0b2b23
to
fc71317
Compare
5fa7fb2
to
a77eb49
Compare
Signed-off-by: Thomas Ferrandiz <[email protected]>
a77eb49
to
35d7917
Compare
Issue: rancher/ecm-distro-tools#383