Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Github Actions #39

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

thomasferrandiz
Copy link
Contributor

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment on lines +58 to +70
- name: Build container image
uses: docker/build-push-action@v5
with:
context: .
push: false
tags: rancher/hardened-k8s-metrics-server:${{ env.TAG }}-arm64
file: Dockerfile
outputs: type=docker
platforms: linux/arm64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, we did something similar in other repos, where you can still benefit from cross-arch cache while still being able to have arch-specific tags:
https://github.com/rancher/cis-operator/blob/master/.github/workflows/release.yml#L42-L44

May not be as relevant as we centralised the logic on the Makefile instead of leaning on GH actions.

Copy link
Member

@macedogm macedogm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main recommendation is to follow the least privilege when generating the token, as Paulo suggested.

Makefile Show resolved Hide resolved
@thomasferrandiz thomasferrandiz force-pushed the migrateToGHA branch 2 times, most recently from d0b2b23 to fc71317 Compare March 21, 2024 10:44
@thomasferrandiz thomasferrandiz force-pushed the migrateToGHA branch 2 times, most recently from 5fa7fb2 to a77eb49 Compare April 10, 2024 14:35
Signed-off-by: Thomas Ferrandiz <[email protected]>
@thomasferrandiz thomasferrandiz merged commit 9d7628a into rancher:master Apr 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants