Fix metrics-server build for v0.7.0 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Buil <[email protected]>
briandowns
approved these changes
Feb 29, 2024
brandond
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
1 - Upgrades to v0.7.0
2 - Adds
-modfile=scripts/go.modwhich is included in upstream too. Otherwise v0.7.0 fails to build3 - Fixes the Makefile. If you add tabs to the Makefile the interpreter things it is a recipe and thus, if we follow the README (which is wrong because it does not add a (BUILD) metadata, we get the error:
As the README has been wrong for a long time and nobody realized, it feels like we don't need that instruction. Anyway, the Makefile is pretty simple and just running 'make' works