Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to github actions #76

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Migrate to github actions #76

merged 1 commit into from
Mar 12, 2024

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented Mar 6, 2024 •
edited
Loading

As we would like to migrate from drone to Github actions, this PR is the first try to achieve that.

Note that it is not disabling the drone for arm64 because it is not yet supported internally

@manuelbuil manuelbuil force-pushed the migrateToGH branch 2 times, most recently from 1bf1e8b to 16a6471 Compare March 11, 2024 11:30
@manuelbuil manuelbuil force-pushed the migrateToGH branch 2 times, most recently from 472eb6f to d31d8ea Compare March 11, 2024 17:32
dereknola
dereknola approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action itself looks good, you may need to address the manifest part brought up.

@galal-hussein
Copy link
Contributor

@manuelbuil manuelbuil force-pushed the migrateToGH branch 3 times, most recently from 73ab2ff to 2478083 Compare March 12, 2024 09:33
@manuelbuil manuelbuil requested a review from tashima42 March 12, 2024 09:47
@manuelbuil manuelbuil force-pushed the migrateToGH branch 4 times, most recently from 92a1ff4 to ff4eb3f Compare March 12, 2024 14:57
@manuelbuil
Migrate to github actions
a25ec0f 
Signed-off-by: Manuel Buil <[email protected]>
@manuelbuil manuelbuil requested a review from tashima42 March 12, 2024 15:31
@manuelbuil manuelbuil merged commit 282d194 into rancher:master Mar 12, 2024
2 checks passed
@manuelbuil manuelbuil deleted the migrateToGH branch March 12, 2024 15:40
@galal-hussein
Copy link
Contributor

@thomasferrandiz thomasferrandiz mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

@tashima42 tashima42 tashima42 approved these changes

@rbrtbnfgl rbrtbnfgl rbrtbnfgl approved these changes

@dereknola dereknola dereknola approved these changes

@galal-hussein galal-hussein Awaiting requested review from galal-hussein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@manuelbuil @galal-hussein @dereknola @rbrtbnfgl @tashima42 @thomasferrandiz