optimize build time by using cross-compilation instead of emulation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasferrandiz
force-pushed
the
optimize-build
branch
from
5a9ffa3 to
e7091f2
Compare
manuelbuil
approved these changes
Apr 3, 2024
manuelbuil
reviewed
Apr 4, 2024
manuelbuil
reviewed
Apr 4, 2024
manuelbuil
reviewed
Apr 4, 2024
manuelbuil
reviewed
Apr 4, 2024
No the point is to have the same Dockerfile optimised for all arch, that's why we use BUILDPLATFORM and TARGETPLATFORM |
thomasferrandiz
force-pushed
the
optimize-build
branch
2 times, most recently
from
36bbc03 to
18a2648
Compare
manuelbuil
approved these changes
Apr 9, 2024
manuelbuil
requested changes
Apr 9, 2024
It should be fixed now |
Signed-off-by: Thomas Ferrandiz <[email protected]>
thomasferrandiz
force-pushed
the
optimize-build
branch
from
910b585 to
b30b03b
Compare
manuelbuil
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should reduce the build time on arm64 from 14 mn to 2mn.
It is based-off #50