Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a fixed golang minor version and fixed k3d version in workflows #1362

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

manno
Copy link
Member

@manno manno commented Mar 2, 2023

^1.19 is equivalent to >=1.19.0 <2.0.0, depending on the github runner's cache, we might get a new version than expected.

See: https://github.com/npm/node-semver#ranges

CI for this PR failed, adding another commit:

The absaoss/k3d-setup action does not install the latest k3d version,
instead a "default" version is used.

This bumps k3d to 5.4.7, so we can get more input on the 'import images'
errors
.

`^1.19` is equivalent to `>=1.19.0 <2.0.0`, depending on the github
runner's cache, we might get a new version than expected.

See: https://github.com/npm/node-semver#ranges
@manno manno requested a review from a team as a code owner March 2, 2023 11:42
The absaoss/k3d-setup action does not install the latest k3d version,
instead a ["default" version is used](AbsaOSS/k3d-action#45).

This bumps k3d to 5.4.7, so we can get more input on the ['import images'
errors](k3d-io/k3d#1072).
@manno manno changed the title Use a fixed golang minor version in workflows Use a fixed golang minor version and fixed k3d version in workflows Mar 2, 2023
@thardeck thardeck merged commit aa5b9d9 into master Mar 2, 2023
@thardeck thardeck deleted the fixed-golang-minor-version-in-ci branch March 2, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants