dry run and tagging functionality #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashima42
reviewed
Jan 16, 2024
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
briandowns
force-pushed
the
add_dry_run
branch
from
10582a4 to
a6934d4
Compare
Signed-off-by: Brian Downs <[email protected]>
tashima42
reviewed
Jan 16, 2024
Signed-off-by: Brian Downs <[email protected]>
tashima42
approved these changes
Jan 16, 2024
brooksn
reviewed
Jan 16, 2024
| @@ -62,6 +128,13 @@ func init() { | |||
| tagCmd.AddCommand(k3sTagSubCmd) | |||
| tagCmd.AddCommand(rke2TagSubCmd) | |||
|
|
|||
| dryRun = tagCmd.PersistentFlags().BoolP("dry-run", "d", false, "Dry run") | |||
There was a problem hiding this comment.
Maybe move this persistent flag to root.go
There was a problem hiding this comment.
I had given that some thought but not all commands will have/need dry-run.
brooksn
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.