Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#326: Backport update to cobra and UX improvements #327

Merged
merged 16 commits into from
Jan 11, 2024

Conversation

tashima42
Copy link
Contributor

@tashima42 tashima42 commented Jan 5, 2024

Closes: #326

What changed

  • Makes the flag owner optional
  • Updates the backport command to use cobra
  • Adds dry run
  • Adds logs
  • Updates running commands to use the ecm exec package
  • Changes the workflow to create issues right after pushing branches, to avoid duplicating issues due to git errors on multiple runs
  • Improves documentation on backport and k3s release

How to test

  • Fork k3s
  • Create an issue on your fork
cd k3s
export GITHUB_TOKEN={YOUR_GITHUB_TOKEN}
cmd/backport/bin/backport-darwin-arm64 -r k3s -i {ISSUE_ID} -o {YOUR_USERNAME} -u {YOUR_USERNAME} -b "release-1.26" -c cd700d9a444df8f03b8ce88cb90261ed1bc49f27 -n

@tashima42 tashima42 changed the title Use urfave/cli for the backport command #326: Use urfave/cli for the backport command Jan 5, 2024
@tashima42 tashima42 marked this pull request as ready for review January 5, 2024 10:06
@tashima42 tashima42 changed the title #326: Use urfave/cli for the backport command #326: Backport update to cobra and bug fixes Jan 9, 2024
@tashima42 tashima42 changed the title #326: Backport update to cobra and bug fixes #326: Backport update to cobra and UX improvements Jan 9, 2024
repository/repository.go Outdated Show resolved Hide resolved
repository/repository.go Outdated Show resolved Hide resolved
@tashima42 tashima42 merged commit fe26695 into rancher:master Jan 11, 2024
2 checks passed
@tashima42 tashima42 deleted the backport-owner branch January 11, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the flag owner optional for the backport command
3 participants