Command to check Rancher dependencies for a RC #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnatasr
changed the title
Signed-off-by: Johnatas <[email protected]>
briandowns
reviewed
Oct 23, 2023
briandowns
reviewed
Oct 23, 2023
briandowns
reviewed
Oct 23, 2023
briandowns
reviewed
Oct 24, 2023
briandowns
reviewed
Oct 24, 2023
briandowns
reviewed
Oct 24, 2023
briandowns
reviewed
Oct 24, 2023
Signed-off-by: Johnatas <[email protected]>
briandowns
reviewed
Oct 26, 2023
briandowns
reviewed
Oct 26, 2023
briandowns
reviewed
Oct 26, 2023
|
Now the layout looks like:
|
Signed-off-by: Johnatas <[email protected]>
briandowns
reviewed
Oct 27, 2023
|
I don't think we should include the output in the form of a log message. A log message is to indicate some information or state of the application itself, not the data being displayed by the application. We should probably output the information without being in a log message. |
johnatasr
force-pushed
the
feat-racher-release-deps-check
branch
from
de1ef07 to
01b8712
Compare
Signed-off-by: Johnatas <[email protected]>
tashima42
reviewed
Nov 17, 2023
Signed-off-by: Johnatas <[email protected]>
Signed-off-by: Johnatas <[email protected]>
brooksn
reviewed
Nov 17, 2023
brooksn
reviewed
Nov 17, 2023
brooksn
reviewed
Nov 17, 2023
brooksn
reviewed
Nov 17, 2023
brooksn
reviewed
Nov 17, 2023
brooksn
reviewed
Nov 17, 2023
brooksn
reviewed
Nov 18, 2023
brooksn
reviewed
Nov 19, 2023
brooksn
reviewed
Nov 19, 2023
brooksn
reviewed
Nov 22, 2023
brooksn
reviewed
Nov 22, 2023
Signed-off-by: Johnatas <[email protected]>
Signed-off-by: Johnatas <[email protected]>
tashima42
requested changes
Nov 27, 2023
Signed-off-by: Johnatas <[email protected]>
brooksn
approved these changes
Nov 28, 2023
briandowns
approved these changes
Nov 28, 2023
tashima42
pushed a commit
to tashima42/ecm-distro-tools
that referenced
this pull request
Dec 19, 2023
* change repo files * func to check all deps and command * add test * last adjusts * improve code * change requires * remove necessity of repo and org Signed-off-by: Johnatas <[email protected]> * more improves Signed-off-by: Johnatas <[email protected]> * more adjusts Signed-off-by: Johnatas <[email protected]> * removing logrus Signed-off-by: Johnatas <[email protected]> * adjust for message Signed-off-by: Johnatas <[email protected]> * adjust for message Signed-off-by: Johnatas <[email protected]> * add template tag Signed-off-by: Johnatas <[email protected]> * add template Signed-off-by: Johnatas <[email protected]> * add more changes Signed-off-by: Johnatas <[email protected]> * using regex for rancher txt files Signed-off-by: Johnatas <[email protected]> * add docs Signed-off-by: Johnatas <[email protected]> * Update rancher.go * remove unsed commit validation Signed-off-by: Johnatas <[email protected]> * split dev deps Signed-off-by: Johnatas <[email protected]> * update doc and requires Signed-off-by: Johnatas <[email protected]> * remove unsed api url Signed-off-by: Johnatas <[email protected]> * more fixes Signed-off-by: Johnatas <[email protected]> * remove func contents Signed-off-by: Johnatas <[email protected]> * more adjusts * add line and content to min version Signed-off-by: Johnatas <[email protected]> * add rancher images export in example --------- Signed-off-by: Johnatas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
dev-andrctags in a sort of filesTypes of Changes
Testing
How to test:
1 - Compile ecm distro-tools with this branch
make2 - Repo with wrong deps:
Local
Remote
Example of exportation:
Linked Issues
#272
User-Facing Change
Further Comments