-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#252: Add set charts branch refs command #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashima42
requested review from
briandowns,
johnatasr,
brooksn,
wgsuse and
luisrojas2
October 9, 2023 14:22
briandowns
reviewed
Oct 9, 2023
briandowns
reviewed
Oct 9, 2023
briandowns
reviewed
Oct 9, 2023
briandowns
reviewed
Oct 9, 2023
tashima42
commented
Oct 10, 2023
briandowns
reviewed
Oct 10, 2023
briandowns
approved these changes
Oct 11, 2023
luisrojas2
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command to update charts branch references in rancher
Closes #252
How to test
Without PR creation:
With PR creation, if you remove
dry-run
it will push changes to your fork and try to create a PR in rancher/rancher