Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#252: Add set charts branch refs command #271

Merged
merged 11 commits into from
Oct 13, 2023
Merged

Conversation

tashima42
Copy link
Contributor

Adds a command to update charts branch references in rancher
Closes #252

How to test

  •   git switch 252-set-chart-references
    
  •   make rancher_release
    
  • Fork github.com/rancher/rancher
    Without PR creation:
  •   cmd/rancher_release/bin/rancher_release set-charts-branch-refs --fork-path YOUR-RANCHER-FORK --base-branch release/v2.8 --current-charts-branch dev-v2.8 --new-charts-branch TEST
    

With PR creation, if you remove dry-run it will push changes to your fork and try to create a PR in rancher/rancher

  •   export GITHUB_TOKEN=your-token
    
  •   cmd/rancher_release/bin/rancher_release set-charts-branch-refs --fork-path YOUR-RANCHER-FORK --base-branch release/v2.8 --current-charts-branch dev-v2.8 --new-charts-branch TEST --create-pr --fork-owner YOUR-GH-USERNAME --dry-run
    

@tashima42 tashima42 marked this pull request as draft October 10, 2023 20:09
@tashima42 tashima42 marked this pull request as ready for review October 10, 2023 21:03
@tashima42 tashima42 requested a review from briandowns October 10, 2023 21:03
@tashima42 tashima42 requested a review from briandowns October 11, 2023 00:33
Copy link
Contributor

@luisrojas2 luisrojas2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tashima42 tashima42 merged commit b705b0f into master Oct 13, 2023
2 checks passed
@tashima42 tashima42 deleted the 252-set-chart-references branch October 13, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a way to automate being able to set the dev or production branch for all Chart references
3 participants