Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create similar post release checks in rancher/rancher that happen in rancherlabs/rancher-prime when tagging a release #246

Closed
deniseschannon opened this issue Aug 31, 2023 · 2 comments · Fixed by #265 or #288
Closed

Create similar post release checks in rancher/rancher that happen in rancherlabs/rancher-prime when tagging a release #246

deniseschannon opened this issue Aug 31, 2023 · 2 comments · Fixed by #265 or #288
Assignees
@tashima42
Labels
priority/high

Comments

@deniseschannon
Copy link

Currently, in Rancher Prime, we have post release checks to confirm the rancher/rancher image and Helm chart are available in the prime registry: https://github.com/rancherlabs/rancher-prime/blob/main/.drone.yml#L277

But I'd like the same check to happen with confirming the rancher/rancher image in Dockerhub and the rancher Helm chart in our Google storage and added into Drone when tagging.
@briandowns
Copy link
Contributor

  • We're going to need an exhaustive list of the images and charts for Rancher and prime.
  • A subcommand to the CLI will need to be created. The primary functionality for the check should exist in library form.
  • Tablized output?

@tashima42 tashima42 mentioned this issue Sep 28, 2023
Merged
tashima42 added a commit that referenced this issue Sep 29, 2023
@tashima42
#246: rancher image check (#265)
d3d56dd 
* add docker package

* add check rancher image command

* rename file

* move url concatenation to docker tag function

* check rancher docker image recieve context

* recieve org repo and archs as arguments

* use constants

* create new yaml decoder for response body

* use rancherOrg

* add http package

* rename to ecmHTTP

* remove bool return

* style fix

---------

Co-authored-by: Pedro Tashima <[email protected]>
@tashima42
Copy link
Contributor

Checking the docker images isn't needed, update to just check if the tag was pushed to latest helm registry

@tashima42 tashima42 reopened this Oct 20, 2023
@tashima42 tashima42 mentioned this issue Oct 24, 2023
Merged
tashima42 added a commit that referenced this issue Oct 24, 2023
@tashima42
#246: Remove docker check from rancher image check (#288)
5f0f1d8 
* remove docker check

* add logs

---------

Co-authored-by: Pedro Tashima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tashima42 tashima42

Labels
priority/high
Projects
None yet
Milestone
No milestone
3 participants
@briandowns @deniseschannon @tashima42