Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging output forms for OpenSearch and Redis #6703

Merged

Conversation

bashofmann
Copy link
Contributor

@bashofmann bashofmann commented Aug 19, 2022

Summary

This adds the new OpenSearch and Redis output plugins to the logging ClusterOutput and Output forms.

Fixes #6701
Fixes #6702

Technical notes summary

The output plugins are available starting with rancher-logging 100.1.3+up3.17.7 in Rancher 2.6.7.

References for the output plugins:
https://banzaicloud.com/docs/one-eye/logging-operator/configuration/plugins/outputs/opensearch/
https://banzaicloud.com/docs/one-eye/logging-operator/configuration/plugins/outputs/redis/

Areas or cases that should be tested

Output and ClusterOutput forms

Screenshot/Video

Bildschirmfoto 2022-08-18 um 14 51 54
Bildschirmfoto 2022-08-18 um 15 24 31

@richard-cox richard-cox added this to the v2.7.0 milestone Aug 19, 2022
@nwmac nwmac modified the milestones: v2.7.0, v2.7.1 Sep 30, 2022
@richard-cox richard-cox modified the milestones: v2.7.2, v2.7.1 Oct 6, 2022
@catherineluse
Copy link
Contributor

I checked the logs for check-plugins-build but it said the logs were deleted because so much time has passed. I think we need to re-run the tests.

@bashofmann bashofmann force-pushed the logging-output-opensearch-redis branch from 29c595f to c78a283 Compare November 21, 2022 09:17
@bashofmann
Copy link
Contributor Author

I rebased the PR on master to rerun all tests.

@catherineluse
Copy link
Contributor

Thank you Bastian.

I have made two changes to this PR:

  • Added "OpenSearch" and "Redis" to the translation file so the names render properly in the dropdown menu for selecting a ClusterOutput type
  • Removed the dropdown menu for selecting an SSL version for OpenSearch. I did this because the value is not persisted on the backend when the version is configured. I know it's not a UI bug because it is not saved when ssl_version is configured in YAML here. I think it's a bug in the OpenSearch docs so I opened a docs issue here https://github.com/banzaicloud/logging-operator-docs/issues/107

I noticed that for the Redis ClusterOutput form, there's no unit for the time for TTL for the Redis keys. But to be fair, there is no unit documented either, so I have opened a docs issue for that too. https://github.com/banzaicloud/logging-operator-docs/issues/108

Copy link
Contributor

@catherineluse catherineluse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - created OpenSearch and Redis ClusterOutputs using the documented options.

@catherineluse catherineluse merged commit ebda539 into rancher:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Logging: Add output form for Redis plugin [FEATURE] Logging: Add output form for OpenSearch plugin
4 participants