-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to skip Cypress dashboard E2E tests using a label or env var #13146
Open
cnotv
wants to merge
11
commits into
rancher:master
Choose a base branch
from
cnotv:feature/13138-cypress-dashboard-env-var
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow to skip Cypress dashboard E2E tests using a label or env var #13146
cnotv
wants to merge
11
commits into
rancher:master
from
cnotv:feature/13138-cypress-dashboard-env-var
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a good change, only a few minor comments, and pr description needs filling out as well.
Yeah sorry for missing the description, I had to drop all out so I just created it 😅 |
cnotv
force-pushed
the
feature/13138-cypress-dashboard-env-var
branch
from
January 17, 2025 23:58
fb54b21
to
54671e5
Compare
cnotv
force-pushed
the
feature/13138-cypress-dashboard-env-var
branch
2 times, most recently
from
January 19, 2025 21:09
4fc5e9c
to
f4ee3da
Compare
cnotv
force-pushed
the
feature/13138-cypress-dashboard-env-var
branch
from
January 19, 2025 21:16
f4ee3da
to
49eb04c
Compare
richard-cox
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13138
Occurred changes and/or fixed issues
Added ability to skip Sorry Cypress dashboard outside the code and keep E2E tests.
Added documentation to the new skip methodologies.
Technical notes summary
E2E script will now have the options to run:
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist