Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip Cypress dashboard E2E tests using a label or env var #13146

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cnotv
Copy link
Member

@cnotv cnotv commented Jan 17, 2025

Summary

Fixes #13138

Occurred changes and/or fixed issues

Added ability to skip Sorry Cypress dashboard outside the code and keep E2E tests.
Added documentation to the new skip methodologies.

Technical notes summary

E2E script will now have the options to run:

  • Using Sorry Cypress dashboard as we always did (CI example)
  • Using just E2E and no dashboard, skipping via label (CI example)
  • Using just E2E and no dashboard, skipping via GitHub settings (CI example)

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a good change, only a few minor comments, and pr description needs filling out as well.

.github/workflows/test.yaml Outdated Show resolved Hide resolved
scripts/e2e Show resolved Hide resolved
@cnotv
Copy link
Member Author

cnotv commented Jan 17, 2025

Yeah sorry for missing the description, I had to drop all out so I just created it 😅
Gonna need to update the documentation too about this. updated

@cnotv cnotv force-pushed the feature/13138-cypress-dashboard-env-var branch from fb54b21 to 54671e5 Compare January 17, 2025 23:58
@cnotv cnotv force-pushed the feature/13138-cypress-dashboard-env-var branch 2 times, most recently from 4fc5e9c to f4ee3da Compare January 19, 2025 21:09
@cnotv cnotv force-pushed the feature/13138-cypress-dashboard-env-var branch from f4ee3da to 49eb04c Compare January 19, 2025 21:16
@cnotv cnotv requested a review from richard-cox January 19, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to skip Cypress dashboard E2E tests using a label or env var
2 participants