Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable e2e tests which test titles #12519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable e2e tests which test titles #12519

wants to merge 1 commit into from

Conversation

codyrancher
Copy link
Contributor

@codyrancher codyrancher commented Nov 6, 2024 •
edited
Loading

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

codyrancher
codyrancher commented Nov 6, 2024
View reviewed changes
cypress/e2e/tests/pages/explorer/dashboard/cluster-dashboard.spec.ts
clusterDashboard.goTo('local');
clusterDashboard.waitForPage(undefined, 'cluster-events');
it('has the correct title', () => {
ClusterDashboardPagePo.navTo();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old way to navigate to the local cluster wasn't working anymore. Switched to the way the other tests were navigating to the same page.

@codyrancher codyrancher added this to the v2.11.0 milestone Nov 6, 2024
@codyrancher codyrancher marked this pull request as ready for review November 6, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eva-vashkevich eva-vashkevich Awaiting requested review from eva-vashkevich

At least 1 approving review is required to merge this pull request.

Assignees

@codyrancher codyrancher

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@codyrancher