Reduce flakiness in explorer/apps/repositories.spec.ts #12445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonasberhe23
approved these changes
Oct 31, 2024
richard-cox
requested changes
Nov 14, 2024
| @@ -48,7 +48,7 @@ describe('Apps', () => { | |||
|
|
|||
| // Ensure this runs after an attempt, rather than all attemps (`after` only runs once after all cypress retries) | |||
| afterEach(() => { | |||
| reposToDelete.forEach((r) => cy.deleteRancherResource('v1', 'catalog.cattle.io.clusterrepos', r)); | |||
| reposToDelete.forEach((r) => cy.deleteRancherResource('v1', 'catalog.cattle.io.clusterrepos', r, false)); | |||
There was a problem hiding this comment.
we could convert this to a for loop and remove the entry on successful deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #12099
This PR corrects some retry logic in one of the e2e tests I'm seeing fail often.
You an see an example of this failure on our sorry cypress instance
.../instance/7a973f49-6fff-40d3-8054-9c5aa95a653b/test/r7Each time this test runs it adds a repo name to
reposToDelete. After each attempt, the afterEach hook tries to delete all repos inreposToDelete. If the test fails and retries, the afterEach hook will be retrying a repo deletion, get a 404 not found, and error out.The simplest fix here seems to be to ignore these errors in afterEach. We could also refactor the test so it only attempts to delete one repo each run.
Checklist